Improves PopUpPanel Rendering #822
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- removes obsolete and overseen `z-index` from `PopUpPanel` static style classes - removes static `<div>`-tag as root element of any `PopUpPanel`. Instead, this `tag` is created by the provided `tagFactory`.This reduces the DOM complexity and enables clients to model their floating content closer to any template. - adjust UI-tests due to new DOM structure within the demo components - downgrade external `scroll-into-view-if-needed` lib version to fit to code base
metin-kale
approved these changes
Dec 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
z-indexfromPopUpPanelstatic style classes<div>-tag as root element of anyPopUpPanel. Instead, thistagis created by the providedtagFactory.This reduces the DOM complexity and enables clients to model their floating content closer to any template.scroll-into-view-if-neededlib version to fit to code basefixes #820