Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use correct methods when raising error during signing/verification with EdDSA #633

Merged
merged 1 commit into from
Oct 9, 2024
Merged

Use correct methods when raising error during signing/verification with EdDSA #633

merged 1 commit into from
Oct 9, 2024

Conversation

hieuk09
Copy link
Contributor

@hieuk09 hieuk09 commented Oct 9, 2024

Description

This Pull Request changes/fixes this error when the key for EdDSA is invalid

NoMethodError:
  undefined method `raise_encode_error!' for an instance of JWT::JWA::Eddsa

This method is renamed to raise_sign_error!. This PR updates raise_decode_error! to raise_verify_error!, too.

Checklist

Before the PR can be merged be sure the following are checked:

  • There are tests for the fix or feature added/changed
  • A description of the changes and a reference to the PR has been added to CHANGELOG.md. More details in the CONTRIBUTING.md

@anakinj anakinj merged commit 42f905c into jwt:main Oct 9, 2024
34 checks passed
@anakinj
Copy link
Member

anakinj commented Oct 9, 2024

Great job. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hieuk09 @anakinj