Skip to content

feat: 2025-may post upgrade changes#41

Merged
fpelliccioni merged 1 commit intomasterfrom
feat/2025may-post-upgrade
Jun 10, 2025
Merged

feat: 2025-may post upgrade changes#41
fpelliccioni merged 1 commit intomasterfrom
feat/2025may-post-upgrade

Conversation

@fpelliccioni
Copy link
Copy Markdown
Contributor

No description provided.

@fpelliccioni fpelliccioni requested a review from Copilot June 10, 2025 13:56
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR implements post-upgrade changes for the 2025-May protocol upgrade by revising the chain state activation types and updating fork settings.

  • In test/transaction_entry.cpp, the deprecated galois activation has been removed and replaced with a new parameter sequence including leibniz and cantor types.
  • In src/settings.cpp and settings.hpp, fork flags and activation time constants are updated (with galois deactivated and cantor introduced) to align with the upcoming upgrade.
  • In src/populate/populate_chain_state.cpp, the chain state constructors are updated to reflect the new upgrade logic by removing galois and adding cantor activation timing.

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
test/transaction_entry.cpp Updated chain state parameters: removed galois and added cantor.
src/settings.cpp Adjusted fork flag assignments to activate leibniz and leave cantor inactive.
src/populate/populate_chain_state.cpp Revised chain state population: excluded galois and added cantor activation timing.
include/kth/blockchain/settings.hpp Updated fork-related boolean flags and activation constants for post-upgrade changes.
Comments suppressed due to low confidence (4)

test/transaction_entry.cpp:45

  • The ordering of activation type parameters has changed (galois removed and leibniz repositioned before introducing cantor). Consider verifying that the new parameter position aligns with the expected chain state constructor requirements.
kth::leibniz_t(0),

src/settings.cpp:105

  • If the bch_cantor fork is not meant to be active post-upgrade, consider adding a clarifying comment indicating that it is intentionally disabled pending further updates.
// forks |= (bch_cantor     ? rule_fork::bch_cantor : 0);

src/populate/populate_chain_state.cpp:293

  • The deprecation of galois_t in favor of a new activation type is clear; ensure that all consumers of the chain_state are updated to reflect this change to prevent any unintended issues at runtime.
// , galois_t(settings_.galois_activation_time)

include/kth/blockchain/settings.hpp:112

  • Replace the placeholder 'xxxxxxxxxx' with a clearly defined constant or a more descriptive placeholder to improve code readability and maintainability.
// 2027-May-15 hard fork, defaults to xxxxxxxxxx: May 15, 2027 12:00:00 UTC protocol upgrade

@fpelliccioni fpelliccioni merged commit e0c0476 into master Jun 10, 2025
7 of 9 checks passed
@fpelliccioni fpelliccioni deleted the feat/2025may-post-upgrade branch June 10, 2025 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants