feat: 2025-may post upgrade changes#41
Merged
fpelliccioni merged 1 commit intomasterfrom Jun 10, 2025
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR implements post-upgrade changes for the 2025-May protocol upgrade by revising the chain state activation types and updating fork settings.
- In test/transaction_entry.cpp, the deprecated galois activation has been removed and replaced with a new parameter sequence including leibniz and cantor types.
- In src/settings.cpp and settings.hpp, fork flags and activation time constants are updated (with galois deactivated and cantor introduced) to align with the upcoming upgrade.
- In src/populate/populate_chain_state.cpp, the chain state constructors are updated to reflect the new upgrade logic by removing galois and adding cantor activation timing.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| test/transaction_entry.cpp | Updated chain state parameters: removed galois and added cantor. |
| src/settings.cpp | Adjusted fork flag assignments to activate leibniz and leave cantor inactive. |
| src/populate/populate_chain_state.cpp | Revised chain state population: excluded galois and added cantor activation timing. |
| include/kth/blockchain/settings.hpp | Updated fork-related boolean flags and activation constants for post-upgrade changes. |
Comments suppressed due to low confidence (4)
test/transaction_entry.cpp:45
- The ordering of activation type parameters has changed (galois removed and leibniz repositioned before introducing cantor). Consider verifying that the new parameter position aligns with the expected chain state constructor requirements.
kth::leibniz_t(0),
src/settings.cpp:105
- If the bch_cantor fork is not meant to be active post-upgrade, consider adding a clarifying comment indicating that it is intentionally disabled pending further updates.
// forks |= (bch_cantor ? rule_fork::bch_cantor : 0);
src/populate/populate_chain_state.cpp:293
- The deprecation of galois_t in favor of a new activation type is clear; ensure that all consumers of the chain_state are updated to reflect this change to prevent any unintended issues at runtime.
// , galois_t(settings_.galois_activation_time)
include/kth/blockchain/settings.hpp:112
- Replace the placeholder 'xxxxxxxxxx' with a clearly defined constant or a more descriptive placeholder to improve code readability and maintainability.
// 2027-May-15 hard fork, defaults to xxxxxxxxxx: May 15, 2027 12:00:00 UTC protocol upgrade
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.