Improve logic of null case

k-tamura · May 28, 2017 · 7d89337 · 7d89337
1 parent 427d401
commit 7d89337
Showing 1 changed file with 6 additions and 6 deletions.
diff --git a/src/main/java/org/t246osslab/easybuggy/vulnerabilities/OpenRedirectServlet.java b/src/main/java/org/t246osslab/easybuggy/vulnerabilities/OpenRedirectServlet.java
@@ -59,13 +59,13 @@ public void doPost(HttpServletRequest request, HttpServletResponse response) thr
             session.setAttribute("userid", userid);
 
             String gotoUrl = request.getParameter("goto");
-            try {
-                URL u = new URL(gotoUrl);
-                gotoUrl = u.toURI().toString();
-            } catch (Exception e) {
-                log.warn("Invalid goto Url: {}", gotoUrl);
-            }
             if (gotoUrl != null) {
+                try {
+                    URL u = new URL(gotoUrl);
+                    gotoUrl = u.toURI().toString();
+                } catch (Exception e) {
+                    log.warn("Invalid goto Url: {}", gotoUrl);
+                }
                 response.sendRedirect(gotoUrl);
             } else {
                 String target = (String) session.getAttribute("target");