Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip ControlPlaneIsStable preflight check for worker machines #1063

Merged
merged 1 commit into from
Feb 12, 2025

Conversation

eromanova
Copy link
Contributor

@eromanova eromanova commented Feb 11, 2025

This PR introduces a temporary fix to address k0sproject/k0smotron#911.

Closes #932

@eromanova eromanova self-assigned this Feb 11, 2025
Copy link
Contributor

@zerospiel zerospiel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it a stable solution? i mean, it looks like a temp kludge to avoid upstream issues, if that is so, i'd put an explicit comment and add the upstream issue to track it easily

@eromanova eromanova force-pushed the skip-preflight-check branch from a9e48bd to 0fd5783 Compare February 12, 2025 08:36
@zerospiel zerospiel merged commit 8a797cf into k0rdent:main Feb 12, 2025
6 checks passed
@eromanova eromanova deleted the skip-preflight-check branch February 12, 2025 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug] Upgrades not working as expected
2 participants