ready for 1.8.0

k0shk0sh · Apr 10, 2017 · 1bdfe45 · 1bdfe45
1 parent 71443f6
commit 1bdfe45
Show file tree

Hide file tree

Showing 7 changed files with 39 additions and 32 deletions.
diff --git a/app/build.gradle b/app/build.gradle
@@ -26,8 +26,8 @@ android {
         applicationId "com.fastaccess.github"
         minSdkVersion 21
         targetSdkVersion 25
-        versionCode 170
-        versionName "1.7.0"
+        versionCode 180
+        versionName "1.8.0"
         signingConfig signingConfigs.signing
         buildConfigString "GITHUB_CLIENT_ID", (buildProperties.secrets['github_client_id'] | buildProperties.notThere['github_client_id']).string
         buildConfigString "GITHUB_SECRET", (buildProperties.secrets['github_secret'] | buildProperties.notThere['github_secret']).string

diff --git a/app/src/main/java/com/fastaccess/data/dao/types/ReviewStateType.java b/app/src/main/java/com/fastaccess/data/dao/types/ReviewStateType.java
@@ -13,13 +13,14 @@ public enum ReviewStateType {
     COMMENTED(R.string.reviewed, R.drawable.ic_eye),
     CHANGES_REQUESTED(R.string.reviewed, R.drawable.ic_eye),
     DISMISSED(R.string.dismissed_review, R.drawable.ic_clear),
-    APPROVED(R.string.reviewed, R.drawable.ic_done);
+    APPROVED(R.string.approved_these_changes, R.drawable.ic_done);
 
     private int stringRes;
     private int drawableRes;
 
     ReviewStateType(@StringRes int stringRes, @DrawableRes int drawableRes) {
         this.stringRes = stringRes;
+        this.drawableRes = drawableRes;
     }
 
     @StringRes public int getStringRes() {

diff --git a/app/src/main/java/com/fastaccess/ui/adapter/viewholder/ReviewsViewHolder.java b/app/src/main/java/com/fastaccess/ui/adapter/viewholder/ReviewsViewHolder.java
@@ -60,7 +60,7 @@ public static ReviewsViewHolder newInstance(ViewGroup viewGroup, BaseRecyclerAda
             }
             if (!InputHelper.isEmpty(review.getBody())) {
                 body.setVisibility(View.VISIBLE);
-                body.setText(review.getBody());
+                body.setText(review.getBody().replaceAll("\n", " "));
             } else {
                 body.setVisibility(View.GONE);
             }

diff --git a/.../fastaccess/ui/modules/repos/pull_requests/pull_request/details/PullRequestPagerView.java b/.../fastaccess/ui/modules/repos/pull_requests/pull_request/details/PullRequestPagerView.java
@@ -261,7 +261,6 @@ public static Intent createIntent(@NonNull Context context, @NonNull String repo
                             .append(getString(R.string.files))
                             .append(" ")
                             .append("(")
-                            .append(" ")
                             .append(String.valueOf(pullRequest.getChangedFiles()))
                             .append(")"));
         }

diff --git a/app/src/main/res/layouts/row_layouts/layout/issue_timeline_row_item.xml b/app/src/main/res/layouts/row_layouts/layout/issue_timeline_row_item.xml
@@ -68,9 +68,6 @@
                     android:layout_width="match_parent"
                     android:layout_height="wrap_content"
                     android:layout_gravity="center"
-                    android:layout_marginTop="@dimen/spacing_micro"
-                    android:ellipsize="end"
-                    android:maxLines="5"
                     android:visibility="gone"
                     tools:text="For a divided large loaf, add some champaign and cinnamon."/>
             </LinearLayout>

diff --git a/app/src/main/res/raw/changelog.html b/app/src/main/res/raw/changelog.html
@@ -1,35 +1,44 @@
 <!DOCTYPE html>
 <html>
-<head>
-    <meta charset="utf-8">
-    <title>Untitled Document.md</title>
-    <style></style>
-</head>
+
 <body id="preview">
 <h2><a id="FastHub_changelog_0"></a>FastHub changelog</h2>
-<h3><a id="Version__170__More_Organization_Support__2"></a>Version 1.7.0 (<em>More Organization Support</em>)</h3>
-<h4><a id="New_Features__Fixes_4"></a>New Features / Fixes</h4>
+<h3><a id="Version__180__IssuesPRs_Search__Filter_Statuses__Reviews__2"></a>Version 1.8.0 (<em>Issues/PRs Search &amp; Filter, Statuses &amp;
+    Reviews</em>)</h3>
+<blockquote>
+    <p>
+        <strong>P.S: If you were using version before 1.6.0 &amp; you can’t see your Organizations list, you’ll need to re-login again so GitHub auth
+            FastHub to list down your Orgs.</strong>
+    </p>
+</blockquote>
+<h4><a id="New_Features_6"></a>New Features</h4>
 <ul>
-    <li>(New) See Organization Feeds.</li>
-    <li>(New) Organization UI.</li>
-    <li>(New) Long click on a notification to mark it as read instead of opening it to mark it as read.</li>
-    <li>(New) Tags now are listed along with Branches to filter either files or commits.</li>
-    <li>(New) See repo size.</li>
-    <li>(Fix) Crash that occured in 1.5.0 - 1.6.0.</li>
-    <li>(Fix) Labels text color now should be readable.</li>
-    <li>(Fix) PullRequests shouldn’t be displayed in Issues.</li>
-    <li>(Fix) Delete menu isn’t visible in own Gist.</li>
-    <li>(Fix) Organization private repos are not listed.</li>
-    <li>(Fix) retaining tabs (count) on orientation change.</li>
-    <li>(Fix) Crash when Repo might be empty.</li>
-    <li>(Fix) Fixed changelog &amp; releases padding which introduced in 1.6.0</li>
-    <li>(Enhancement) Displaying message upon clicking on dropdown icon in Drawer if user isn’t tied to any organization.</li>
-    <li>More stuff.</li>
+    <li>(New) Filter/Search Repo Issues &amp; PRs.</li>
+    <li>(New) PullRequest reviews.</li>
+    <li>(New) PullRequest build statuses.</li>
+    <li>(New) PullRequest modified files.</li>
+    <li>(New) Navigate to directory from CodeViewer.</li>
+    <li>(New) Showing file name in CodeView.</li>
+    <li>(New) Showing events icon in feeds.</li>
+    <li>(New) Showing comments body &amp; issue/pr title in feeds.</li>
+    <li>(New) Some animations here and there.</li>
+    <li>(New) Mark notification as read from notification panel.</li>
+    <li>(New) Showing total conversations, commits &amp; files count in PR.</li>
+    <li>(New) Closing/Opening issue/PullRequest should refresh the associated list.</li>
+    <li>(New) Displaying icon in branches &amp; tags to differentiate between them.</li>
+    <li>(Fix) Repo size.</li>
+    <li>(Fix) Clicking on Org avatar opens users view.</li>
+    <li>(Fx/Enhanced) Some phrases.</li>
+    <li>(Fix) Tapping files icon does nothing.</li>
+    <li>(Fix/Enhancement) Up Button (Toolbar back button) navigation.</li>
+    <li>(Fix/Enhancement) Showing Repo name in some screen that requires that.</li>
+    <li>(Fix) Releases order in Offline mode.</li>
+    <li>A loooot More stuff…</li>
 </ul>
 <blockquote>
     <p>P.S: Releases will usually happen in Sunday unless if urgent release, so please stay tuned for more stuff :).</p>
 </blockquote>
 <p><strong>Thank you very much</strong></p>
-
 </body>
-</html>
+
+</html>
diff --git a/app/src/main/res/values/strings.xml b/app/src/main/res/values/strings.xml
@@ -357,4 +357,5 @@
     <string name="commit_can_be_merged">This pull request can be merged</string>
     <string name="reviewed">reviewed</string>
     <string name="dismissed_review">dismissed their review</string>
+    <string name="approved_these_changes">approved these changes</string>
 </resources>