Use private cgroup namespaces for cgroup v2 #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
twz123
commented
Dec 19, 2023
Comment on lines
+313
to
+337
| // FIXME: How to clean this up? Especially when Docker is being run | ||
| // on a different machine? |
There was a problem hiding this comment.
I think this is the only remaining concern with this approach. Generally, it improves the isolation of bootloose machines a lot, but all the cgroups created inside those machines won't be cleaned up. They would, if we could somehow leverage the Docker-managed cgroups, but, due to the chicken-and-egg problem stated above, we can't.
There was a problem hiding this comment.
Maybe we could run bootloose itself in a Docker container to do the cleanup? This would be a pretty heavy cleanup procedure, but it is the only way I can think of to tackle this.
twz123
force-pushed
the
private-cgroupns
branch
from
1e57e94
to
3b2b42e
Compare
twz123
force-pushed
the
private-cgroupns
branch
from
3b2b42e
to
ef74d05
Compare
Using the host's cgroup namespace along with a writable mount of the entire cgroup fs messes with container isolation quite a bit. The main purpose of this is to get a writable mount of the cgroup fs inside containers, so that init systems are able to set up their own cgroups accordingly. Use a different approach to achieve the same effect: Use a private cgroup namespace. Privileged containers will automatically have write access. A read-write mount is only performed when running non-privileged containers. Signed-off-by: Tom Wieczorek <twieczorek@mirantis.com>
twz123
force-pushed
the
private-cgroupns
branch
from
ef74d05
to
48233bc
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the host's cgroup namespace along with a writable mount of the entire cgroup fs messes with container isolation quite a bit. The main purpose of this is to get a writable mount of the cgroup fs inside containers, so that init systems are able to set up their own cgroups accordingly.
Use a different approach to achieve the same effect: Use a private cgroup namespace. Privileged containers will automatically have write access. A read-write mount is only performed when running non-privileged containers.