-
Notifications
You must be signed in to change notification settings - Fork 379
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Let API subcommand accept the runtime config via stdin #5422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
twz123
force-pushed
the
api-runtime-config-stdin
branch
2 times, most recently
from
January 9, 2025 07:34
1c7d54b
to
98be923
Compare
This pull request has merge conflicts that need to be resolved. |
twz123
force-pushed
the
api-runtime-config-stdin
branch
from
January 9, 2025 11:40
98be923
to
54337cf
Compare
twz123
force-pushed
the
api-runtime-config-stdin
branch
from
January 10, 2025 15:56
54337cf
to
a4e9e5a
Compare
ncopa
previously approved these changes
Jan 14, 2025
This pull request has merge conflicts that need to be resolved. |
twz123
force-pushed
the
api-runtime-config-stdin
branch
from
January 14, 2025 12:42
a4e9e5a
to
0624550
Compare
This pull request has merge conflicts that need to be resolved. |
twz123
force-pushed
the
api-runtime-config-stdin
branch
from
January 14, 2025 13:26
0624550
to
1f9ad6d
Compare
This pull request has merge conflicts that need to be resolved. |
Have a more functional apporach of assembling the HTTP handlers. Signed-off-by: Tom Wieczorek <twieczorek@mirantis.com>
The API subcommand is not designed to run as a standalone process. Rather, it's intended to be executed under the supervision of a k0s controller. Therefore, the usual way of loading the configuration is inappropriate. Instead, have this subcommand accept the runtime configuration via stdin. This will prevent a false fallback to a generated default configuration, as well as loading the configuration from a possibly existing default configuration file that has nothing to do with the one used by the supervising process. Signed-off-by: Tom Wieczorek <twieczorek@mirantis.com>
twz123
force-pushed
the
api-runtime-config-stdin
branch
from
January 15, 2025 15:01
1f9ad6d
to
b17f100
Compare
ncopa
approved these changes
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The API subcommand is not designed to run as a standalone process. Rather, it's intended to be executed under the supervision of a k0s controller. Therefore, the usual way of loading the configuration is inappropriate. Instead, have this subcommand accept the runtime configuration via stdin. This will prevent a false fallback to a generated default configuration, as well as loading the configuration from a possibly existing default configuration file that has nothing to do with the one used by the supervising process.
Type of change
How Has This Been Tested?
Checklist: