Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not include runn.* in the include runner store. #1123

Merged
merged 2 commits into from
Dec 20, 2024
Merged

Do not include runn.* in the include runner store. #1123

merged 2 commits into from
Dec 20, 2024

Conversation

k1LoW
Copy link
Owner

@k1LoW k1LoW commented Dec 20, 2024

SSIA.

@k1LoW k1LoW self-assigned this Dec 20, 2024

This comment has been minimized.

Copy link
Contributor

BenchmarkManyRunbooks-4

main (-) #1123 (94c4b0b) +/-
Number of iterations 1 1 0
Nanoseconds per iteration 3,607,876,370 ns/op 3,466,512,839 ns/op -141,363,531 ns/op
Bytes allocated per iteration 1,382,422,496 B/op 1,382,419,120 B/op -3,376 B/op
Allocs per iteration 18,999,908 allocs/op 19,000,163 allocs/op 255 allocs/op
Metadata
main (-) #1123 (94c4b0b)
goos linux linux
goarch amd64 amd64
pkg github.com/k1LoW/runn github.com/k1LoW/runn
cpu AMD EPYC 7763 64-Core Processor AMD EPYC 7763 64-Core Processor

BenchmarkOpenAPI3-4

main (-) #1123 (94c4b0b) +/-
Number of iterations 1 1 0
Nanoseconds per iteration 4,727,727,345 ns/op 4,732,445,548 ns/op 4,718,203 ns/op
Bytes allocated per iteration 2,297,002,112 B/op 2,297,148,560 B/op 146,448 B/op
Allocs per iteration 31,627,752 allocs/op 31,632,621 allocs/op 4,869 allocs/op
Metadata
main (-) #1123 (94c4b0b)
goos linux linux
goarch amd64 amd64
pkg github.com/k1LoW/runn github.com/k1LoW/runn
cpu AMD EPYC 7763 64-Core Processor AMD EPYC 7763 64-Core Processor

BenchmarkSingleRunbook-4

main (-) #1123 (94c4b0b) +/-
Number of iterations 26 25 -1
Nanoseconds per iteration 43,460,534 ns/op 43,731,800 ns/op 271,266 ns/op
Bytes allocated per iteration 23,152,453 B/op 23,201,632 B/op 49,179 B/op
Allocs per iteration 183,417 allocs/op 183,453 allocs/op 36 allocs/op
Metadata
main (-) #1123 (94c4b0b)
goos linux linux
goarch amd64 amd64
pkg github.com/k1LoW/runn github.com/k1LoW/runn
cpu AMD EPYC 7763 64-Core Processor AMD EPYC 7763 64-Core Processor

Reported by octocov

Copy link
Contributor

Code Metrics Report

main (8fc27a4) #1123 (94c4b0b) +/-
Coverage 64.6% 64.6% -0.1%
Code to Test Ratio 1:0.7 1:0.7 +0.0
Test Execution Time 6m32s 5m59s -33s
Details
  |                     | main (8fc27a4) | #1123 (94c4b0b) |  +/-  |
  |---------------------|----------------|-----------------|-------|
- | Coverage            |          64.6% |           64.6% | -0.1% |
  |   Files             |             77 |              77 |     0 |
  |   Lines             |           9008 |            8996 |   -12 |
- |   Covered           |           5825 |            5814 |   -11 |
+ | Code to Test Ratio  |          1:0.7 |           1:0.7 |  +0.0 |
  |   Code              |          16497 |           16482 |   -15 |
  |   Test              |          12616 |           12616 |     0 |
+ | Test Execution Time |          6m32s |           5m59s |  -33s |

Code coverage of files in pull request scope (78.1% → 77.3%)

Files Coverage +/-
store.go 77.3% -0.8%

Reported by octocov

@k1LoW k1LoW merged commit 043ffa9 into main Dec 20, 2024
9 checks passed
@k1LoW k1LoW deleted the remove-runn- branch December 20, 2024 03:02
@github-actions github-actions bot mentioned this pull request Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant