Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If loop.count <= 0, skip step. #1145

Merged
merged 1 commit into from
Jan 9, 2025
Merged

If loop.count <= 0, skip step. #1145

merged 1 commit into from
Jan 9, 2025

Conversation

k1LoW
Copy link
Owner

@k1LoW k1LoW commented Jan 9, 2025

Fix: #1144

@k1LoW k1LoW self-assigned this Jan 9, 2025
Copy link
Contributor

github-actions bot commented Jan 9, 2025

BenchmarkManyRunbooks-4

main (-) #1145 (ddd4b33) +/-
Number of iterations 1 1 0
Nanoseconds per iteration 3,922,101,889 ns/op 4,029,425,238 ns/op 107,323,349 ns/op
Bytes allocated per iteration 1,383,794,600 B/op 1,383,806,760 B/op 12,160 B/op
Allocs per iteration 19,140,341 allocs/op 19,140,011 allocs/op -330 allocs/op
Metadata
main (-) #1145 (ddd4b33)
goos linux linux
goarch amd64 amd64
pkg github.com/k1LoW/runn github.com/k1LoW/runn
cpu AMD EPYC 7763 64-Core Processor AMD EPYC 7763 64-Core Processor

BenchmarkOpenAPI3-4

main (-) #1145 (ddd4b33) +/-
Number of iterations 1 1 0
Nanoseconds per iteration 5,222,148,007 ns/op 5,124,085,834 ns/op -98,062,173 ns/op
Bytes allocated per iteration 2,297,243,552 B/op 2,297,044,224 B/op -199,328 B/op
Allocs per iteration 31,645,929 allocs/op 31,631,872 allocs/op -14,057 allocs/op
Metadata
main (-) #1145 (ddd4b33)
goos linux linux
goarch amd64 amd64
pkg github.com/k1LoW/runn github.com/k1LoW/runn
cpu AMD EPYC 7763 64-Core Processor AMD EPYC 7763 64-Core Processor

BenchmarkSingleRunbook-4

main (-) #1145 (ddd4b33) +/-
Number of iterations 20 19 -1
Nanoseconds per iteration 50,900,641 ns/op 55,088,830 ns/op 4,188,189 ns/op
Bytes allocated per iteration 23,185,594 B/op 23,182,034 B/op -3,560 B/op
Allocs per iteration 184,837 allocs/op 184,825 allocs/op -12 allocs/op
Metadata
main (-) #1145 (ddd4b33)
goos linux linux
goarch amd64 amd64
pkg github.com/k1LoW/runn github.com/k1LoW/runn
cpu AMD EPYC 7763 64-Core Processor AMD EPYC 7763 64-Core Processor

Reported by octocov

Copy link
Contributor

github-actions bot commented Jan 9, 2025

Code Metrics Report

main (b9d3384) #1145 (ddd4b33) +/-
Coverage 63.3% 63.3% +0.0%
Code to Test Ratio 1:0.7 1:0.7 -0.1
Test Execution Time 7m7s 6m37s -30s
Details
  |                     | main (b9d3384) | #1145 (ddd4b33) |  +/-  |
  |---------------------|----------------|-----------------|-------|
+ | Coverage            |          63.3% |           63.3% | +0.0% |
  |   Files             |             78 |              78 |     0 |
  |   Lines             |           9005 |            9007 |    +2 |
+ |   Covered           |           5706 |            5708 |    +2 |
- | Code to Test Ratio  |          1:0.7 |           1:0.7 |  -0.1 |
  |   Code              |          16552 |           16555 |    +3 |
  |   Test              |          12658 |           12658 |     0 |
+ | Test Execution Time |           7m7s |           6m37s |  -30s |

Code coverage of files in pull request scope (80.5% → 80.6%)

Files Coverage +/-
operator.go 80.6% +0.0%

Reported by octocov

@k1LoW k1LoW added the minor label Jan 9, 2025
@k1LoW k1LoW merged commit 6cc8154 into main Jan 9, 2025
9 checks passed
@k1LoW k1LoW deleted the fix-loop-zero branch January 9, 2025 12:21
@github-actions github-actions bot mentioned this pull request Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"loop: 0" gives "failed to record: store.stepMapKeys is zero" error
1 participant