Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Added support for using defer and force options with other runners. #1168

Merged
merged 1 commit into from
Feb 11, 2025

Conversation

marimelon
Copy link
Contributor

This PR fixes an issue where defer and force options could not be used in combination with other runners.

Currently, the validation incorrectly rejects valid configurations that should be supported according to the documentation.

The following valid configuration results in a validation error:

desc: Test for defer
steps:
  - desc: step 1
    test: len(steps) == 0

  - defer: true
    desc: defererd step a
    test: true
    exec:
      command: echo "deferred step a"

Error message:

./runn run testdata/book/defer.yml --debug --scopes run:exec                                                                                                                                                                                                             6s
Error: failed to load runbook testdata/book/defer.yml: invalid steps[1]. runners that cannot be running at the same time are specified: map[defer:%!s(bool=true) desc:defererd step a exec:map[command:echo "deferred step a"] test:%!s(bool=true)]

@k1LoW k1LoW added the bug Something isn't working label Feb 11, 2025
@k1LoW
Copy link
Owner

k1LoW commented Feb 11, 2025

@marimelon Thank you!!!

@k1LoW k1LoW merged commit 1cbf84a into k1LoW:main Feb 11, 2025
7 checks passed
@github-actions github-actions bot mentioned this pull request Feb 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants