Skip to content

fix: the secrets: section in the included runbook is not working #1220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 15, 2025

Conversation

k1LoW
Copy link
Owner

@k1LoW k1LoW commented Apr 15, 2025

Fix #1203

@k1LoW k1LoW added the bug Something isn't working label Apr 15, 2025
@k1LoW k1LoW self-assigned this Apr 15, 2025
Copy link
Contributor

BenchmarkManyRunbooks-4

main (-) #1220 (b88dfbc) +/-
Number of iterations 1 1 0
Nanoseconds per iteration 3,674,516,173 ns/op 3,958,666,865 ns/op 284,150,692 ns/op
Bytes allocated per iteration 1,388,802,360 B/op 1,388,334,824 B/op -467,536 B/op
Allocs per iteration 19,567,655 allocs/op 19,566,979 allocs/op -676 allocs/op
Metadata
main (-) #1220 (b88dfbc)
goos linux linux
goarch amd64 amd64
pkg github.com/k1LoW/runn github.com/k1LoW/runn
cpu AMD EPYC 7763 64-Core Processor AMD EPYC 7763 64-Core Processor

BenchmarkOpenAPI3-4

main (-) #1220 (b88dfbc) +/-
Number of iterations 1 1 0
Nanoseconds per iteration 3,083,442,862 ns/op 2,893,699,972 ns/op -189,742,890 ns/op
Bytes allocated per iteration 1,265,211,872 B/op 1,265,533,272 B/op 321,400 B/op
Allocs per iteration 21,240,387 allocs/op 21,250,433 allocs/op 10,046 allocs/op
Metadata
main (-) #1220 (b88dfbc)
goos linux linux
goarch amd64 amd64
pkg github.com/k1LoW/runn github.com/k1LoW/runn
cpu AMD EPYC 7763 64-Core Processor AMD EPYC 7763 64-Core Processor

BenchmarkSingleRunbook-4

main (-) #1220 (b88dfbc) +/-
Number of iterations 22 21 -1
Nanoseconds per iteration 46,888,022 ns/op 47,898,294 ns/op 1,010,272 ns/op
Bytes allocated per iteration 23,267,716 B/op 23,258,509 B/op -9,207 B/op
Allocs per iteration 189,115 allocs/op 189,104 allocs/op -11 allocs/op
Metadata
main (-) #1220 (b88dfbc)
goos linux linux
goarch amd64 amd64
pkg github.com/k1LoW/runn github.com/k1LoW/runn
cpu AMD EPYC 7763 64-Core Processor AMD EPYC 7763 64-Core Processor

Reported by octocov

Copy link
Contributor

Code Metrics Report

main (ce84e78) #1220 (b88dfbc) +/-
Coverage 63.3% 63.3% -0.1%
Code to Test Ratio 1:0.7 1:0.7 -0.1
Test Execution Time 7m21s 7m19s -2s
Details
  |                     | main (ce84e78) | #1220 (b88dfbc) |  +/-  |
  |---------------------|----------------|-----------------|-------|
- | Coverage            |          63.3% |           63.3% | -0.1% |
  |   Files             |             78 |              78 |     0 |
  |   Lines             |           9067 |            9069 |    +2 |
+ |   Covered           |           5746 |            5747 |    +1 |
- | Code to Test Ratio  |          1:0.7 |           1:0.7 |  -0.1 |
  |   Code              |          16701 |           16703 |    +2 |
+ |   Test              |          12821 |           12822 |    +1 |
+ | Test Execution Time |          7m21s |           7m19s |   -2s |

Code coverage of files in pull request scope (90.6% → 90.7%)

Files Coverage +/-
include.go 90.7% +0.1%

Reported by octocov

@k1LoW k1LoW merged commit 06cd37d into main Apr 15, 2025
9 checks passed
@k1LoW k1LoW deleted the fix-included-secrets branch April 15, 2025 15:57
@github-actions github-actions bot mentioned this pull request Apr 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The secrets: section in the included runbook is not working
1 participant