Skip to content

refactor: modernize #1237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 4, 2025
Merged

refactor: modernize #1237

merged 1 commit into from
May 4, 2025

Conversation

k1LoW
Copy link
Owner

@k1LoW k1LoW commented May 4, 2025

SSIA.

@k1LoW k1LoW self-assigned this May 4, 2025
Copy link
Contributor

github-actions bot commented May 4, 2025

BenchmarkManyRunbooks-4

main (-) #1237 (9a18fef) +/-
Number of iterations 1 1 0
Nanoseconds per iteration 3,677,328,973 ns/op 3,908,614,027 ns/op 231,285,054 ns/op
Bytes allocated per iteration 1,387,902,504 B/op 1,388,083,664 B/op 181,160 B/op
Allocs per iteration 19,552,521 allocs/op 19,552,800 allocs/op 279 allocs/op
Metadata
main (-) #1237 (9a18fef)
goos linux linux
goarch amd64 amd64
pkg github.com/k1LoW/runn github.com/k1LoW/runn
cpu AMD EPYC 7763 64-Core Processor AMD EPYC 7763 64-Core Processor

BenchmarkOpenAPI3-4

main (-) #1237 (9a18fef) +/-
Number of iterations 1 1 0
Nanoseconds per iteration 2,904,414,525 ns/op 2,875,561,044 ns/op -28,853,481 ns/op
Bytes allocated per iteration 1,268,930,432 B/op 1,266,640,784 B/op -2,289,648 B/op
Allocs per iteration 21,310,765 allocs/op 21,260,018 allocs/op -50,747 allocs/op
Metadata
main (-) #1237 (9a18fef)
goos linux linux
goarch amd64 amd64
pkg github.com/k1LoW/runn github.com/k1LoW/runn
cpu AMD EPYC 7763 64-Core Processor AMD EPYC 7763 64-Core Processor

BenchmarkSingleRunbook-4

main (-) #1237 (9a18fef) +/-
Number of iterations 21 25 4
Nanoseconds per iteration 47,686,980 ns/op 47,287,289 ns/op -399,691 ns/op
Bytes allocated per iteration 23,272,168 B/op 23,291,134 B/op 18,966 B/op
Allocs per iteration 189,103 allocs/op 189,095 allocs/op -8 allocs/op
Metadata
main (-) #1237 (9a18fef)
goos linux linux
goarch amd64 amd64
pkg github.com/k1LoW/runn github.com/k1LoW/runn
cpu AMD EPYC 7763 64-Core Processor AMD EPYC 7763 64-Core Processor

Reported by octocov

Copy link
Contributor

github-actions bot commented May 4, 2025

Code Metrics Report

main (80dc24f) #1237 (9a18fef) +/-
Coverage 62.8% 62.8% -0.1%
Code to Test Ratio 1:0.7 1:0.7 +0.0
Test Execution Time 6m35s 7m11s +36s
Details
  |                     | main (80dc24f) | #1237 (9a18fef) |  +/-  |
  |---------------------|----------------|-----------------|-------|
- | Coverage            |          62.8% |           62.8% | -0.1% |
  |   Files             |             79 |              79 |     0 |
  |   Lines             |           9078 |            9043 |   -35 |
- |   Covered           |           5710 |            5685 |   -25 |
+ | Code to Test Ratio  |          1:0.7 |           1:0.7 |  +0.0 |
  |   Code              |          16762 |           16708 |   -54 |
- |   Test              |          13070 |           13064 |    -6 |
- | Test Execution Time |          6m35s |           7m11s |  +36s |

Code coverage of files in pull request scope (69.9% → 69.9%)

Files Coverage +/- Status
bind.go 100.0% 0.0% modified
book.go 71.7% -0.5% modified
cdpfn.go 71.0% -0.5% modified
db.go 76.2% 0.0% modified
grpc.go 76.4% 0.0% modified
internal/store/store.go 51.6% -0.3% modified
operator.go 80.5% -0.1% modified
option.go 60.6% +0.3% modified
testutil/db.go 81.2% +1.2% modified
testutil/runbook.go 0.0% 0.0% modified
vars.go 91.0% -0.2% modified
yaml.go 42.2% 0.0% modified

Reported by octocov

@k1LoW k1LoW merged commit 12f5442 into main May 4, 2025
9 checks passed
@k1LoW k1LoW deleted the modernize branch May 4, 2025 07:32
@github-actions github-actions bot mentioned this pull request May 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant