fix: remove list secret rule #1221
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michael12312
force-pushed
the
fix-issue-1122
branch
from
0387246
to
4787e09
Compare
Signed-off-by: michael12312 <jun.wang@fmr.com>
brianwarner
force-pushed
the
fix-issue-1122
branch
from
4787e09
to
df2d0d7
Compare
|
hi @AlexsJones Can you please help to review this PR? In this PR, i removed the list secrets rules from clusterrole, also all the rules needed are added. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1122
📑 Description
✅ Checks
ℹ Additional Information