Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: dump #1322

Merged
merged 11 commits into from
Nov 12, 2024
Merged

feat: dump #1322

merged 11 commits into from
Nov 12, 2024

Conversation

AlexsJones
Copy link
Member

@AlexsJones AlexsJones commented Nov 11, 2024 •
edited
Loading

This adds the ability for users to create dump files for assisting in debugging.

✅ Checks

  • [x ] My pull request adheres to the code style of this project
  • [x ] My code requires changes to the documentation
  • [x ] I have updated the documentation as required
  • [x ] All the tests have passed

ℹ Additional Information

@AlexsJones
feat: reverting the cncf runners
977ac43 
Signed-off-by: AlexsJones <alexsimonjones@gmail.com>
@AlexsJones
feat: creating a dump file for debugging
afaec9e 
Signed-off-by: AlexsJones <alexsimonjones@gmail.com>
@AlexsJones AlexsJones requested review from a team as code owners November 11, 2024 11:26
@AlexsJones
Merge branch 'main' into feat/dump
155c035
@AlexsJones
chore: ran the linter
cd2505a 
Signed-off-by: AlexsJones <alexsimonjones@gmail.com>
matthisholleville
matthisholleville requested changes Nov 11, 2024
View reviewed changes
Copy link
Contributor

@matthisholleville matthisholleville left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left one comment.

Shouldn't we update the documentation with the new set of command ?

cmd/dump/dump.go Show resolved Hide resolved
@AlexsJones
chore: updated
e0364a6 
Signed-off-by: AlexsJones <alexsimonjones@gmail.com>
@AlexsJones
chore: updated
d539f8f 
Signed-off-by: AlexsJones <alexsimonjones@gmail.com>
@AlexsJones
chore: improved the function readme
f87b327 
Signed-off-by: AlexsJones <alexsimonjones@gmail.com>
@AlexsJones
feat: added k8sgpt version info
48c9d93 
Signed-off-by: AlexsJones <alexsimonjones@gmail.com>
@AlexsJones
feat: added k8sgpt version info
9c56235 
Signed-off-by: AlexsJones <alexsimonjones@gmail.com>
@AlexsJones
Copy link
Member Author

Left one comment.

Shouldn't we update the documentation with the new set of command ?

Will do it in the k8sgpt docs

@AlexsJones AlexsJones mentioned this pull request Nov 12, 2024
Merged
@AlexsJones
Copy link
Member Author

@matthisholleville I opened a PR for the documentation k8sgpt-ai/docs#128

matthisholleville
matthisholleville approved these changes Nov 12, 2024
View reviewed changes
Copy link
Contributor

@matthisholleville matthisholleville left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@AlexsJones AlexsJones merged commit da266b3 into main Nov 12, 2024
10 checks passed
@AlexsJones AlexsJones deleted the feat/dump branch November 12, 2024 12:04
@github-actions github-actions bot mentioned this pull request Nov 12, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthisholleville matthisholleville matthisholleville approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Backlog
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AlexsJones @matthisholleville