Change logic to prevent device-plugin daemonset spec change

[AMacedoP]

Instead of adding a NodeSelectorRequirement per NodePolicy we add all the NodeSelectors to a single NodeSelectorRequirent so they can all be sorted. This will prevent that the daemonset's node selector changes when there are multiple NodePolicies applied.

[github-actions]

Thanks for your PR,
To run vendors CIs, Maintainers can use one of:

• /test-all: To run all tests for all vendors.
• /test-e2e-all: To run all E2E tests for all vendors.
• /test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs, Maintainers can use one of:

• /skip-all: To skip all tests for all vendors.
• /skip-e2e-all: To skip all E2E tests for all vendors.
• /skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
  Best regards.

[zeeke]

hi @AMacedoP , the problem you're describing has probably already been solved by:

• add sort for the policy on the sriovOperatorConfig controller #721
  can you check that?

That said, I'm not against the proposed changes, as they make the code clearer and more resilient.

[AMacedoP]

@zeeke yes, that PR also solves my problem. How do you want to proceed with this PR? If you want I can resolve the failed test cases and merge it.

[zeeke]

Please, fix the unit test and wait for the other community member's feedback.

@adrianchiris , @SchSeba WDYT?

[SchSeba]

Hi @AMacedoP,

Thanks for the PR!
I am working on a different solution that I think will be better here.
My idea is to leave the device plugin with one node selector something like sriov-device-plugin-deployed
and the daemon will remove and add the label when it needs to reset the device plugin

I think that is cleaner let me know what you think

[AMacedoP]

@SchSeba that looks like a good solution. In that case what should we do with this PR?

[SchSeba]

If possible I would like to close this one in favor of #747

@AMacedoP let me know what do you think

Thanks!

[AMacedoP]

@SchSeba will close this PR. Do you have an expected release date for a new version with the changes in #721?

Thanks!