Add OperatorConfig option to indicate deployment with OLM #547
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fig. If cass-operator has this configuration parameter set, it will set a default serviceAccount to cass-operator-cassandra-default-sa
…he ReconciliationContext
adejanovski
approved these changes
Jun 30, 2023
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Alternative approach to #545 , instead of polling the Kubernetes API if we actually deployed with the ServiceAccount, we use OperatorConfig to modify the OLM deployment to indicate deployment scenario.
This reduces Role requirements for the operator as well as call to api-server (even if cached read).
controller_manager_config.yaml receives this additional line:
olmDeployment: falseWhich is set to true in the bundle creation. We still add nonroot Role & required ServiceAccounts
Which issue(s) this PR fixes:
Fixes #541
Checklist