Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert commit that rolled back logger.Dockerfile, never push :latest #556

Merged
merged 1 commit into from
Jul 27, 2023

Conversation

burmanm
Copy link
Contributor

@burmanm burmanm commented Jul 26, 2023

What this PR does:

Which issue(s) this PR fixes:
Fixes #

Checklist

  • Changes manually tested
  • Automated Tests added/updated
  • Documentation added/updated
  • CHANGELOG.md updated (not required for documentation PRs)
  • CLA Signed: DataStax CLA

@burmanm burmanm requested a review from a team as a code owner July 26, 2023 15:05
@github-actions
Copy link

No linked issues found. Please add the corresponding issues in the pull request description.
Use GitHub automation to close the issue when a PR is merged

@burmanm
Copy link
Contributor Author

burmanm commented Jul 26, 2023

For context, this is where the version-tag is used for system-logger and cass-operator to ensure our tests don't just use :latest and be happy:

https://github.com/k8ssandra/cass-operator/blob/master/Makefile#L208

@burmanm
Copy link
Contributor Author

burmanm commented Jul 26, 2023

Ah.. need to fix the Kustomize version again:

/home/runner/work/cass-operator/cass-operator/bin/kustomize version is not expected v5.0.3. Removing it before installing.
test -s /home/runner/work/cass-operator/cass-operator/bin/kustomize || { curl -s "https://raw.githubusercontent.com/kubernetes-sigs/kustomize/master/hack/install_kustomize.sh" | bash -s -- 5.0.3 /home/runner/work/cass-operator/cass-operator/bin; }
Github rate-limiter failed the request. Either authenticate or wait a couple of minutes.

Copy link
Contributor

@emerkle826 emerkle826 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine, just a couple of questions regarding the image and use in OpenShift

logger.Dockerfile Show resolved Hide resolved
@burmanm burmanm merged commit cf4cbc0 into k8ssandra:master Jul 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants