cassandradatacenter_types: allow 1length rack name #714
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
No linked issues found. Please add the corresponding issues in the pull request description. |
|
Hey, thanks for the PR. I'll try to investigate if there was a reason why the restriction was 2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does: allow more flexibility in the naming of rack by allowing names with only 1char.
Rationale: on cloud-environments (ex: when using
GoogleCloudSnitchfor my use-case) & using the simple mapping: datacenter=cloudProvider-region & rack=cloudProvider-zone, we want to define justa,b,cas rack name, which is not possible today.AFAIK, this is mainly impacting when we have some existing clusters (created outside of the operator, with 1long rack names) and we want to migrate to the operator (using the same rack-name for a safe migration)
NB: the reason for this "min 2" is unclear to me, I only found the commit that introduced it but no explanation
Which issue(s) this PR fixes: no issue created
Checklist