Destat NPC #119
Destat NPC #119
Conversation
There was a problem hiding this comment.
Hello, thanks for this PR.
I've left a few comments and questions. I've read the code but I haven't actually tested it.
It'll be up to @kaansoral to decide whether to merge or not but it mostly looks good to me.
node/server.js
Outdated
|
|
||
| socket.on("destat", function (data) { | ||
| var player = players[socket.id]; | ||
| var item = player.items[data.item_num]; |
There was a problem hiding this comment.
The variable was num in the client-side function.
| var item = player.items[data.num]; | ||
| if (!item) { | ||
| return fail_response("no_item"); | ||
| } | ||
| var def = G.items[item.name]; |
There was a problem hiding this comment.
Why do you redefine item and def? Am I missing something?
There was a problem hiding this comment.
I copied a lot of the code from socket.on("locksmith"), it seems there is duplicate code there too.
| if (!player || player.user) { | ||
| return fail_response("cant_in_bank"); | ||
| } | ||
| if (!player.computer && simple_distance(G.maps.desertland.ref.scrollsmith, player) > B.sell_dist) { |
There was a problem hiding this comment.
Should probable use distance for consistency?
There was a problem hiding this comment.
simple_distance is consistent with locksmith, which I based the code on.
| var scrolltype = item.stat_type + "scroll"; | ||
| if (scrolltype == "mp_costscroll") { | ||
| scrolltype = "mpcostscroll"; |
There was a problem hiding this comment.
Did you try with all scrolls to make sure they all follow the pattern except mpcostscroll?
Remove duplicate item definitions.
Telokis
added
Type: feature
This pull request adds an NPC to Desertland that allows players to remove the stat modifier from an item that has had one applied via scrolls. This process only works on items that have a stat applied to them, i.e.
item.stat_type != null.The number of scrolls returned is equivalent to the number of scrolls that would be required to apply the stat to the item if it were at level 0. For example, if Wanderer's Breeches (common at +0) were upgraded to level 7 (they are High grade at +7), and then Intelligence scrolls were used to apply Intelligence to the item (10 scrolls would be required), and then the item were brought to this NPC, the NPC would return only 1 Intelligence scroll.
Additionally, the cost scales with the number of scrolls that would be returned - it is 10 times the value of
G.items[scrollname].gtimes the quantity of scrolls returned. For our example with Wanderer's Breeches +7, it would cost 8,000 gold (at the time of writing, prices may change for rarer scrolls).As a precaution, the NPC cannot return scrolls for which there exist no scroll definition: Suppose that an item somehow had "charisma", then the NPC would not return an invalid "charismascroll" item.
The NPC can be found in Desertland, near the purple Scorpion spawn.