simplify and clarify calculate_monster_score calculations #151
+37
−44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
earthiverse
commented
Aug 20, 2024
node/server.js
Outdated
| if (isMerchant && simple_distance(p, player) <= 600) { | ||
| // Nearby merchants reduce the points | ||
| if (sameOwner) { | ||
| score -= 0.2 / divisor; // -Deduct points if our merchant is nearby |
earthiverse
commented
Aug 20, 2024
| if (sameOwner) { | ||
| score -= 0.2 / divisor; // -Deduct points if our merchant is nearby | ||
| } else { | ||
| score -= 0.1 / divisor; // Deduct points if a merchant in our party is nearby |
earthiverse
commented
Aug 20, 2024
|
|
||
| const isMerchant = p.type === "merchant"; | ||
| if (sameOwner && sameParty && !isMerchant) { | ||
| score += 0.3 / divisor; // +0.3 points for each additional non-merchant character of ours in our party (even if they are far away) |
There was a problem hiding this comment.
Old lines 2330 & 2337
ATLUSio
reviewed
Aug 20, 2024
|
|
||
| for (const id in players) { | ||
| const p = players[id]; | ||
| if (p.id === player.id) { |
There was a problem hiding this comment.
Could skip the get call on id of p and just use id directly given by the for loop
There was a problem hiding this comment.
It might be a different ID?
ATLUSio
approved these changes
Aug 20, 2024
There was a problem hiding this comment.
The proposed changes are simpler to read and appear to be logically the same. As far as I can tell, the code will produce the same outputs as the original one; however, I think it'll also be marginally more performant, too. So cleaner, leaner, and the same outputs
Telokis
added
Type: enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pretty self-explanatory.
Can someone check that the logic ends up being the same?