-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docker development environment #96
base: main
Are you sure you want to change the base?
Conversation
…ppserver patching and added healthcheck for compose
… building docker image
…eck for an empty list but only if it was set
I'll review it more later, but I'm curious about the hot reloading, when the server is started, it performs different funtions that generate data. If I add a new item in Sure hotloading might work for the frontend client ( But what if I change something in |
Hi there, sorry for not fully explaining the hot reloading. Docker cant really manage your state, so if you are changing actual started container files it would need a restart yes or if calculates things with the changed data. I could have explained better that with hot reloading i ment changing frontend/client things in /js folder for example. Then you would only need to refresh your browser to view the changes. |
I noticed that there was no docker dev environment for this game!
So i created one, it uses docker compose and i have updated the readme on how to use it.
Some benefits of dockerization with this:
Together with volume mapping it has hot reloading. So if you make a change, you can refresh the page and see your changes.
Healthcheck, you have a dev/app/backend and client/game server. The client/game server only will start once the backend is running properly.
No hassle of setting up the whole enviroment and editing your host file etc. Just one command and you have it running.
Automatic cloning of the devapp backend and patching it to support dockerization.
Aswell as instead of having hardcoded data in the config.py it uses the data from your secrets file (Renamed that to secrets_data as there is a default python package named secrets).