Enable Visual Regression testing with Chromatic #702
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ghislain89
force-pushed
the
chore/chromatic
branch
from
ee74d56
to
9a3ee7b
Compare
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Ignored Deployments
|
Ghislain89
requested review from
eileenmguo,
sstraatemans,
alber70g and
webpro
as code owners
Ghislain89
changed the title
eileenmguo
approved these changes
Aug 1, 2023
Ghislain89
force-pushed
the
chore/chromatic
branch
from
08e1ec5
to
99c851a
Compare
webpro
reviewed
Aug 7, 2023
Ghislain89
force-pushed
the
chore/chromatic
branch
from
c02f7b7
to
cba877f
Compare
webpro
approved these changes
Aug 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
adds basic visual regression testing with Chromatic. If a change is done to the react-ui library that results in a visual change, this will have to be approved (or denied). Workflow only runs if a commit is being done in the react-ui packages.
Enables a11y for Storybook allowing developers to directly check storybook for any accessibility issues with components.