Navigation Header component #706
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Ignored Deployments
|
timoheddes
force-pushed
the
feat/header-component
branch
from
6828b28
to
5aaacd6
Compare
MRVDH
approved these changes
Aug 1, 2023
MRVDH
approved these changes
Aug 1, 2023
timoheddes
force-pushed
the
feat/header-component
branch
from
d7bcab3
to
91f4c43
Compare
timoheddes
force-pushed
the
feat/header-component
branch
from
f585435
to
c500130
Compare
eileenmguo
reviewed
Aug 2, 2023
packages/libs/react-ui/src/components/NavHeader/NavHeader.css.ts
Outdated
Show resolved
Hide resolved
packages/libs/react-ui/src/components/NavHeader/NavHeader.css.ts
Outdated
Show resolved
Hide resolved
packages/libs/react-ui/src/components/NavHeader/NavHeader.css.ts
Outdated
Show resolved
Hide resolved
packages/libs/react-ui/src/components/NavHeader/NavHeader.stories.children.tsx
Outdated
Show resolved
Hide resolved
timoheddes
commented
Aug 2, 2023
timoheddes
force-pushed
the
feat/header-component
branch
from
3ee82e6
to
d1c170c
Compare
eileenmguo
reviewed
Aug 8, 2023
| export type INavItems = INavItem[]; | ||
|
|
||
| export interface INavHeaderNavigationProps { | ||
| children: React.ReactNode; |
There was a problem hiding this comment.
Small improvement: You can type the children to be an array of a specific component
export interface IBreadcrumbsProps {
children?: FunctionComponentElement<IBreadcrumbItemProps>[];
icon?: (typeof ProductIcon)[keyof typeof ProductIcon];
}
eileenmguo
approved these changes
Aug 8, 2023
eileenmguo
reviewed
Aug 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements Navigation Header component.
Figma Link
Also created new Logo component, see its readme for some more info.
Note that there is no mobile design available. In the Docs website this was solved by creating a hamburger menu but Steven indicated that this doesn't work ideal and Isa is still going to look into it.