Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(@kadena/react-ui): Add CONTRIBUTING.md #760

Merged
merged 14 commits into from
Aug 21, 2023

Conversation

eileenmguo
Copy link
Contributor

@eileenmguo eileenmguo commented Aug 8, 2023

Adding unspoken conventions used within the component library


@vercel
Copy link

vercel bot commented Aug 8, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 21, 2023 9:10am
3 Ignored Deployments
Name Status Preview Comments Updated (UTC)
alpha-docs ⬜️ Ignored (Inspect) Visit Preview Aug 21, 2023 9:10am
immutable-records ⬜️ Ignored (Inspect) Visit Preview Aug 21, 2023 9:10am
tools ⬜️ Ignored (Inspect) Visit Preview Aug 21, 2023 9:10am

Copy link
Contributor

@realdreamer realdreamer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall it's looking good! Kudos for documenting this 🎉

packages/libs/react-ui/CONTRIBUTING.md Outdated Show resolved Hide resolved
packages/libs/react-ui/CONTRIBUTING.md Outdated Show resolved Hide resolved
packages/libs/react-ui/CONTRIBUTING.md Outdated Show resolved Hide resolved
packages/libs/react-ui/CONTRIBUTING.md Outdated Show resolved Hide resolved
packages/libs/react-ui/CONTRIBUTING.md Outdated Show resolved Hide resolved
packages/libs/react-ui/CONTRIBUTING.md Outdated Show resolved Hide resolved
@timoheddes timoheddes removed the request for review from bearni95 August 21, 2023 07:08
Previously when the `Button` was used with an icon, it needed to be composed
like this:

```jsonc
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought md has support for jsx?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just copied it from the other file, but this is better! Updated 👍

@eileenmguo eileenmguo merged commit 0ce1927 into main Aug 21, 2023
4 checks passed
@eileenmguo eileenmguo deleted the chore/react-ui-contributing-docs branch August 21, 2023 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants