[react-ui] ProfileCard component implementation #765
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sub-components; lint warning fixes
bearni95
requested review from
eileenmguo,
sstraatemans and
timoheddes
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Ignored Deployments
|
eileenmguo
reviewed
Aug 9, 2023
packages/libs/react-ui/src/components/ProfileCard/ProfileCard.tsx
Outdated
Show resolved
Hide resolved
eileenmguo
reviewed
Aug 9, 2023
packages/libs/react-ui/src/components/ProfileCard/ProfileCard.tsx
Outdated
Show resolved
Hide resolved
… being undefined or not
eileenmguo
approved these changes
Aug 10, 2023
ash-vd
pushed a commit
that referenced
this pull request
Aug 16, 2023
* added profile card component, fully based on parameters, rather than sub-components; lint warning fixes * code cleanup; made links and tags optional * made rendering of the tags and links blocks conditional upon the vars being undefined or not
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For now it uses props, as it's composition seems quite static. Open to structuring as subcomponents, but sounds a bit messier to implement @eileenmguo @realdreamer @timoheddes