refactor: Footer to match NavHeader #773
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Ignored Deployments
|
timoheddes
force-pushed
the
feat/update-footer
branch
from
826e288
to
5ebdd6a
Compare
eileenmguo
reviewed
Aug 11, 2023
eileenmguo
reviewed
Aug 11, 2023
packages/libs/react-ui/src/components/NavFooter/NavFooter.stories.tsx
Outdated
Show resolved
Hide resolved
eileenmguo
reviewed
Aug 11, 2023
packages/libs/react-ui/src/components/NavFooter/NavFooterLink.tsx
Outdated
Show resolved
Hide resolved
eileenmguo
reviewed
Aug 11, 2023
packages/libs/react-ui/src/components/NavFooter/NavFooterLink.tsx
Outdated
Show resolved
Hide resolved
packages/libs/react-ui/src/components/NavFooter/NavFooterLink.tsx
Outdated
Show resolved
Hide resolved
eileenmguo
approved these changes
Aug 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After implementing the NavHeader component we noticed the Footer doesn't entirely meet our standards. This PR fixes that and also renames the Footer and its files to NavFooter.