Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
KIP-0037 to KIP-0041: Standardized JSON-RPC Methods for Wallet-DApp Communication #71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
KIP-0037 to KIP-0041: Standardized JSON-RPC Methods for Wallet-DApp Communication #71
Changes from 12 commits
9cb0d91
6fedc7d
871f701
0723f5c
2b14e68
8539a82
46033cc
1742122
3c572d2
08d8c17
3b96f1d
e2cb4c9
a87bc57
1e3ea2f
d0dc30f
7c516ef
3dd77df
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Balking at
guard
being a mnemonic for a keyset when you very well might have a guard be a governance function like a user-guard or something more complicated. If it's a keyset, you should just say it's a keyset.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
they renamed the field
keyset
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
up to what confirmation depth?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This spec defines only the communication protocol, these kind of things are up to the wallets to handle. If this requirement suggests otherwise I'd rather remove the requirement from the KIP.