Adds /account/balance endpoint #1047
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LindaOrtega
commented
May 13, 2020
src/Chainweb/Rosetta/RestAPI.hs
Outdated
| -- Value of the transaction in atomic units represented as an | ||
| -- arbitrary-sized signed integer. | ||
| amount :: Integer | ||
| amount = floor $ k * (realToFrac $ (10 :: Integer) ^ numDecimals) |
There was a problem hiding this comment.
Is this the correct approach?
sirlensalot
approved these changes
May 19, 2020
| -- | Guarantees that the `ChainId` given actually belongs to this | ||
| -- `ChainwebVersion`. | ||
| readChainIdText :: ChainwebVersion -> T.Text -> Maybe ChainId | ||
| readChainIdText v c = do | ||
| cid <- readMaybe @Word (T.unpack c) | ||
| mkChainId v cid | ||
|
|
||
|
|
||
| kdaToRosettaAmount :: Decimal -> Amount |
There was a problem hiding this comment.
Suggest a quick unit test for just this function
There was a problem hiding this comment.
I merged this PR into the #1050 and added a unit test for kdaToRosettaAmount there
|
Closing this as it was merged into #1050 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Research possible bug (checkpointer error keeps being thrown when I hit this endpoint in non-genesis case)Can't replicate and it seems to work fine with a local mining node now.