#21 - Update nginx conf, add note about chainweb version name for minimal devnet #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trendzetter
reviewed
Nov 13, 2023
| @@ -227,7 +226,9 @@ db/0/sqlite | |||
| - As of 2.18, this is a height of 500. It takes four hours or so to reach this from scratch. | |||
| - The rest api should be exposed on your localhost, so you can use the command below to check the height of chain 0. | |||
|
|
|||
| `curl -s http://localhost:8080/chainweb/0.0/development/cut | jq '.hashes."'0'".height'` | |||
| `curl -s http://localhost:8080/chainweb/0.0/fast-development/cut | jq '.hashes."'0'".height` | |||
There was a problem hiding this comment.
if you change the nginx port to 80 shouldn't it be 80 here as well instead of 8080?
There was a problem hiding this comment.
I left the 8080:80 port mapping in docker-compose.yml as it was, so nginx can be reached on port 8080 from outside of the docker network.
An alternative to my change would have been to update the port mapping to 8080:8080 instead of updating the nginx config.
I created the issue and PR cause I spent a lot more time than was necessary to get the devnet up and running because of missing the fast-development chainweb version in the docs and this port misconfiguration, so hope it saves other people some time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.