Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gaussian distribution fix #72

Merged
merged 11 commits into from
Dec 20, 2024
Merged

Gaussian distribution fix #72

merged 11 commits into from
Dec 20, 2024

Conversation

RemDelaporteMathurin
Copy link
Collaborator

@RemDelaporteMathurin RemDelaporteMathurin commented Dec 19, 2024 •
edited
Loading

We noticed that the gaussian distribution function was not normalised therefore its area was not unity!

@kaelyndunnell kaelyndunnell self-requested a review December 20, 2024 06:28
RemDelaporteMathurin
RemDelaporteMathurin commented Dec 20, 2024
View reviewed changes
src/hisp/festim_models/mb_model.py Outdated Show resolved Hide resolved
src/hisp/festim_models/mb_model.py Outdated Show resolved Hide resolved
src/hisp/helpers.py Outdated Show resolved Hide resolved
src/hisp/plamsa_data_handling/main.py Outdated Show resolved Hide resolved
src/hisp/plamsa_data_handling/main.py Outdated Show resolved Hide resolved
@RemDelaporteMathurin RemDelaporteMathurin linked an issue Dec 20, 2024 that may be closed by this pull request
Check mesh refinement for real exposure conditions #52
Closed
kaelyndunnell and others added 5 commits December 20, 2024 15:11
@kaelyndunnell @RemDelaporteMathurin
Update src/hisp/plamsa_data_handling/main.py
3d6655a 
Co-authored-by: Rémi Delaporte-Mathurin <40028739+RemDelaporteMathurin@users.noreply.github.com>
@kaelyndunnell @RemDelaporteMathurin
Update src/hisp/plamsa_data_handling/main.py
b247f43 
Co-authored-by: Rémi Delaporte-Mathurin <40028739+RemDelaporteMathurin@users.noreply.github.com>
@kaelyndunnell
added documentation to gaussian_distribution
e0b1eed
@kaelyndunnell
decrease some B mesh refinement
04a2e2c
@kaelyndunnell
decrease B model rtol
1d282b8
kaelyndunnell
kaelyndunnell approved these changes Dec 20, 2024
View reviewed changes
Copy link
Owner

@kaelyndunnell kaelyndunnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if we want to play around more with B mesh refinement to get rtol down to 1e-10, but otherwise looks great to me!

@kaelyndunnell kaelyndunnell merged commit 790ff61 into main Dec 20, 2024
3 checks passed
@kaelyndunnell kaelyndunnell deleted the gaussian_distribution_fix branch December 20, 2024 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaelyndunnell kaelyndunnell kaelyndunnell approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Check mesh refinement for real exposure conditions
2 participants
@RemDelaporteMathurin @kaelyndunnell