FE: Messages: Format JSON arrays #994
Merged
+3
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We currently only format JSON objects but we can detect JSON arrays and format them as well for a better user experience when messages contain arrays of JSON objects. Signed-off-by: Yarden Shoham <git@yardenshoham.com>
kapybro
bot
added
status/triage
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hi yardenshoham! 👋
Welcome, and thank you for opening your first PR in the repo!
Please wait for triaging by our maintainers.
Please take a look at our contributing guide.
Haarolean
approved these changes
Mar 31, 2025
germanosin
approved these changes
Apr 2, 2025
Haarolean
added
type/enhancement
|
@yardenshoham thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently only format JSON objects, but we can detect and format JSON arrays as well, which will improve the user experience when messages contain arrays of JSON objects.
Before:
After:
What changes did you make?
Changed JSON message detection to include messages starting with
[, not only{.Is there anything you'd like reviewers to focus on?
No.
How Has This Been Tested?
Checklist
A picture of a cute animal
