feat: private working set v2.1 governance + global toggle quarantine mode + dashboard UX polish#75
Merged
kaffolder7 merged 13 commits intomainfrom Apr 10, 2026
Merged
Conversation
Introduce a utility to render button labels with qualifiers (e.g., words in parentheses) more elegantly. This utility handles different parentheses styles, trims unnecessary spaces, and updates the display of certain buttons in the DashboardPrivateWorkingSetPanel component. These changes improve visual clarity and maintain consistency across button labels, ensuring that button qualifiers are clearly and uniformly presented.
Change button alignment from justify-end to justify-start in the DashboardPrivateWorkingSetPanel component. This adjustment is intended to improve the visual alignment of the button with the rest of the form elements, enhancing the overall user interface consistency and readability.
Reorganize buttons in DashboardPrivateWorkingSetPanel to ensure the "Refresh from source books" button is always displayed, and consolidate its functionality within the same section regardless of the advanced controls visibility. Modify related tests to ensure the correct buttons are rendered and tested in both simple and advanced modes. This change enhances readability and maintainability by reducing redundancy in the button handling logic and ensures consistent functionality across different panel states.
Simplify the constructor in EnsurePrivateWorkingSetEnabled middleware by using a property promotion for RegistrationSettingsService. This change enhances readability and modernizes the codebase. Update the test suite PrivateWorkingSetCardDavTest by adding an import for AddressBookPrivateWorkingSetService and removing redundant namespaces. This specifically improves test maintainability and reduces potential namespace-related issues. These changes improve the code's maintainability and follow modern PHP practices, ensuring that the logic for enabling private working sets is efficiently handled.
Move the Apple Contacts Compatibility section below the Private Working Set panel in the UI and reposition it in the user-guide.md. This ensures that users can access Apple Contacts Compatibility features and documentation. Previously, the section was misplaced, which could lead to confusion or lack of access for users seeking these functionalities.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR delivers the full Private Working Set (PWS) v2/v2.1 rollout with stronger server-side governance, a global admin kill-switch (quarantine mode), major dashboard UX cleanup, sharing panel improvements, localization updates, and docs updates.
What Changed
private_working_set_enabled) with default OFF.PATCH /api/admin/settings/private-working-set.private_working_set_enabledto auth/public config payloads (/api/public/config,/api/auth/login,/api/auth/me).403).Refreshalways visible,Resetadvanced-only.docs/,docs/landing/) for governance, API, troubleshooting, and user/admin guidance.Upgrade / Ops Notes
ENABLE_PRIVATE_WORKING_SET=falseby default.ENABLE_PRIVATE_WORKING_SET=trueor enable via Admin Control Center.Reviewer Focus
AddressBookPrivateWorkingSetServiceandEnsurePrivateWorkingSetEnabled.