Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: differentiate producers to the same topic with aliases #68

Merged
merged 15 commits into from
Jun 26, 2024
Merged

fix: differentiate producers to the same topic with aliases #68

merged 15 commits into from
Jun 26, 2024

Conversation

thalesmg
Copy link
Contributor

@thalesmg thalesmg force-pushed the fix-differentiate-producers-mkII branch 9 times, most recently from 33cec57 to 636a005 Compare June 24, 2024 17:08
@thalesmg thalesmg force-pushed the fix-differentiate-producers-mkII branch from 636a005 to 45ad5df Compare June 24, 2024 17:17
@thalesmg thalesmg marked this pull request as ready for review June 24, 2024 17:41
@thalesmg thalesmg mentioned this pull request Jun 24, 2024
Merged
9 tasks
zmstone
zmstone reviewed Jun 25, 2024
View reviewed changes
Copy link
Contributor

@zmstone zmstone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wolff_producer will need to be changed so the processes will not try to write to the same files when buffer on disk.

src/wolff_client.erl Outdated Show resolved Hide resolved
@thalesmg thalesmg force-pushed the fix-differentiate-producers-mkII branch from b7c6cf1 to 9cd9eb5 Compare June 25, 2024 13:46
@thalesmg thalesmg requested a review from zmstone June 25, 2024 14:13
zmstone
zmstone reviewed Jun 25, 2024
View reviewed changes
src/wolff_producer.erl Outdated Show resolved Hide resolved
zmstone
zmstone reviewed Jun 25, 2024
View reviewed changes
src/wolff_client.erl Outdated Show resolved Hide resolved
zmstone
zmstone reviewed Jun 25, 2024
View reviewed changes
src/wolff_producers.erl Outdated Show resolved Hide resolved
zmstone
zmstone reviewed Jun 25, 2024
View reviewed changes
src/wolff.erl Outdated Show resolved Hide resolved
zmstone
zmstone reviewed Jun 25, 2024
View reviewed changes
src/wolff_client.erl Outdated Show resolved Hide resolved
zmstone
zmstone reviewed Jun 25, 2024
View reviewed changes
src/wolff_producers.erl Outdated Show resolved Hide resolved
zmstone
zmstone reviewed Jun 25, 2024
View reviewed changes
src/wolff_producers.erl Outdated Show resolved Hide resolved
zmstone
zmstone reviewed Jun 25, 2024
View reviewed changes
src/wolff_producers.erl Outdated Show resolved Hide resolved
zmstone
zmstone reviewed Jun 25, 2024
View reviewed changes
src/wolff_producers.erl Outdated Show resolved Hide resolved
@thalesmg thalesmg force-pushed the fix-differentiate-producers-mkII branch from b952f13 to 4c80bf7 Compare June 25, 2024 20:17
@thalesmg thalesmg force-pushed the fix-differentiate-producers-mkII branch from b0ed634 to 9fda9cf Compare June 25, 2024 20:30
zmstone
zmstone reviewed Jun 25, 2024
View reviewed changes
src/wolff_producer.erl Outdated Show resolved Hide resolved
zmstone
zmstone reviewed Jun 25, 2024
View reviewed changes
src/wolff_producers.erl Outdated Show resolved Hide resolved
zmstone
zmstone reviewed Jun 25, 2024
View reviewed changes
src/wolff_client.erl Outdated Show resolved Hide resolved
zmstone
zmstone reviewed Jun 26, 2024
View reviewed changes
src/wolff.erl Outdated Show resolved Hide resolved
src/wolff_producer.erl Outdated Show resolved Hide resolved
zmstone
zmstone reviewed Jun 26, 2024
View reviewed changes
src/wolff.erl Outdated Show resolved Hide resolved
zmstone
zmstone reviewed Jun 26, 2024
View reviewed changes
src/wolff_producers.erl Outdated Show resolved Hide resolved
zmstone
zmstone reviewed Jun 26, 2024
View reviewed changes
src/wolff_client.erl Outdated Show resolved Hide resolved
@thalesmg thalesmg force-pushed the fix-differentiate-producers-mkII branch from 55bade7 to 7fc4bfc Compare June 26, 2024 14:54
@thalesmg thalesmg force-pushed the fix-differentiate-producers-mkII branch from 7fc4bfc to ba4f06b Compare June 26, 2024 15:14
@thalesmg thalesmg force-pushed the fix-differentiate-producers-mkII branch from ba4f06b to 86e5298 Compare June 26, 2024 15:15
@thalesmg thalesmg merged commit a13b2eb into kafka4beam:main Jun 26, 2024
6 checks passed
@thalesmg thalesmg deleted the fix-differentiate-producers-mkII branch June 26, 2024 16:42
@thalesmg
Copy link
Contributor Author

tagged 2.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zmstone zmstone zmstone approved these changes

@ieQu1 ieQu1 ieQu1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thalesmg @zmstone @ieQu1