refactor: get ready to support multiple topics in one wolff_producers #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zmstone
force-pushed
the
0719-refactor-prepare-fore-multiple-topics
branch
from
3c4a18b
to
b4c044c
Compare
thalesmg
approved these changes
Jul 22, 2024
| @@ -529,3 +540,31 @@ ensure_timer_cancelled(Tref) when is_reference(Tref) -> | |||
| ok; | |||
| ensure_timer_cancelled(_) -> | |||
| ok. | |||
|
|
|||
| supervisor_child_id(St) -> | |||
There was a problem hiding this comment.
Should the supervisor use this same function to make it consistent by construction?
There was a problem hiding this comment.
producer id is not exactly the supervisor child id.
i'll make it simpler
Topic name in producers table is either namespaced by client-ID or group-name.
thalesmg
approved these changes
Jul 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.