Merge pull request #504 from kagemomiji/issue497-fix-star-rest-api

#497 fix star rest api
kagemomiji · Jun 15, 2024 · 8583b58 · 8583b58
2 parents e68efb1 + b1ef393
commit 8583b58
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 6 deletions.
diff --git a/airsonic-main/pom.xml b/airsonic-main/pom.xml
@@ -49,12 +49,11 @@
         <dependency>
             <groupId>io.dropwizard.metrics</groupId>
             <artifactId>metrics-core</artifactId>
-            <version>4.2.25</version>
         </dependency>
         <dependency>
             <groupId>io.dropwizard.metrics</groupId>
             <artifactId>metrics-jmx</artifactId>
-            <version>4.2.25</version>
+            <version>4.2.26</version>
         </dependency>
         <!-- END Metrics -->
 
@@ -726,7 +725,7 @@
             <plugin>
                 <groupId>org.apache.maven.plugins</groupId>
                 <artifactId>maven-jxr-plugin</artifactId>
-                <version>3.3.2</version>
+                <version>3.4.0</version>
             </plugin>
         </plugins>
     </reporting>

diff --git a/airsonic-main/src/main/java/org/airsonic/player/controller/SubsonicRESTController.java b/airsonic-main/src/main/java/org/airsonic/player/controller/SubsonicRESTController.java
@@ -1485,13 +1485,12 @@ private void starOrUnstar(HttpServletRequest request, HttpServletResponse respon
             }
         }
         for (int artistId : getIntParameters(request, "artistId")) {
-            if (artistService.starOrUnstar(artistId, username, star)) {
-                writeEmptyResponse(request, response);
-            } else {
+            if (!artistService.starOrUnstar(artistId, username, star)) {
                 error(request, response, ErrorCode.NOT_FOUND, "Artist not found: " + artistId);
                 return;
             }
         }
+        writeEmptyResponse(request, response);
     }
 
     @RequestMapping({"/getStarred", "/getStarred.view"})

diff --git a/pom.xml b/pom.xml
@@ -188,6 +188,11 @@
                 <artifactId>lucene-backward-codecs</artifactId>
                 <version>${lucene.version}</version>
             </dependency>
+            <dependency>
+                <groupId>io.dropwizard.metrics</groupId>
+                <artifactId>metrics-core</artifactId>
+                <version>4.2.26</version>
+        </dependency>
         </dependencies>
     </dependencyManagement>