Refactor auroraboot command strings to use strings.Builder #203
+31
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: jimmykarily <2794419+jimmykarily@users.noreply.github.com>
Collaborator
|
@copilot there are other similar invocations of |
Co-authored-by: jimmykarily <2794419+jimmykarily@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Update legacy scripts to auroraboot commands
Refactor auroraboot command string to use strings.Builder
Dec 2, 2025
Co-authored-by: jimmykarily <2794419+jimmykarily@users.noreply.github.com>
jimmykarily
reviewed
Dec 2, 2025
| @@ -1,5 +1,4 @@ | |||
| //go:build !ignore_autogenerated | |||
| // +build !ignore_autogenerated | |||
Author
There was a problem hiding this comment.
That was an unintended side effect from running make fmt, which triggered code generation and removed the old-style build constraint. I've reverted those changes so the PR now only modifies controllers/job.go. (4939c02)
Author
Refactored all similar |
Copilot
AI
changed the title
Refactor auroraboot command string to use strings.Builder
Refactor auroraboot command strings to use strings.Builder
Dec 2, 2025
Co-authored-by: jimmykarily <2794419+jimmykarily@users.noreply.github.com>
jimmykarily
merged commit 5ad6a28
into
3779-fix-cloud-image-building
8 of 15 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cloudImgCmdto use strings.BuilderazureCmdto use strings.Builder for consistencygceCmdto use strings.Builder for consistency✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.