Skip to content

Commit

Permalink
refactor(redhat-resource-optimization): remove @janus-idp/cli and dyn…
Browse files Browse the repository at this point in the history
…amic plugin build step (backstage#1848)

Signed-off-by: Christoph Jerolimov <jerolimov+git@redhat.com>
Signed-off-by: Kaja Hannestad <kaja.hannestad@vipps.no>
  • Loading branch information
christoph-jerolimov authored and kajahanne committed Nov 11, 2024
1 parent c93d581 commit ee3c9e7
Show file tree
Hide file tree
Showing 7 changed files with 64 additions and 1,342 deletions.
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
'@backstage-community/plugin-redhat-resource-optimization-backend': patch
'@backstage-community/plugin-redhat-resource-optimization': patch
---

Removed `export-dynamic` script and Janus IDP cli from the build process and npm release.
2 changes: 0 additions & 2 deletions workspaces/redhat-resource-optimization/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,6 @@
"postinstall": "cd ../../ && yarn install",
"prettier:check": "prettier --check .",
"new": "backstage-cli new --scope @backstage-community",
"export-dynamic": "yarn workspaces foreach -A run export-dynamic",
"versions:bump": "yarn backstage-cli versions:bump"
},
"workspaces": {
Expand All @@ -46,7 +45,6 @@
"@backstage/e2e-test-utils": "^0.1.1",
"@backstage/repo-tools": "^0.10.0",
"@changesets/cli": "^2.27.1",
"@janus-idp/cli": "^1.11.1",
"@microsoft/api-extractor-model": "^7.29.2",
"@microsoft/tsdoc": "^0.15.0",
"@microsoft/tsdoc-config": "^0.17.0",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@
"./package.json": "./package.json"
},
"files": [
"app-config.rhdh.yaml",
"app-config.dynamic.yaml",
"dist",
"config.d.ts"
],
Expand All @@ -55,7 +55,6 @@
"scripts": {
"build": "backstage-cli package build",
"clean": "backstage-cli package clean",
"export-dynamic": "yarn run -T janus-cli package export-dynamic-plugin --embed-as-dependencies",
"lint": "backstage-cli package lint",
"postpack": "backstage-cli package postpack",
"prepack": "backstage-cli package prepack",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -46,9 +46,8 @@
"./package.json": "./package.json"
},
"files": [
"app-config.rhdh.yaml",
"dist",
"dist-scalprum"
"app-config.dynamic.yaml",
"dist"
],
"license": "Apache-2.0",
"main": "src/index.ts",
Expand All @@ -75,7 +74,6 @@
"scripts": {
"build": "backstage-cli package build",
"clean": "backstage-cli package clean",
"export-dynamic": "yarn run -T janus-cli package export-dynamic-plugin",
"lint": "backstage-cli package lint",
"postpack": "backstage-cli package postpack",
"prepack": "backstage-cli package prepack",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,12 @@ PLUGIN_REGISTRY_URL="${PLUGIN_REGISTRY_URL:-"http://plugin-registry:8080"}"

yarn install
yarn build:all
yarn export-dynamic

for plugin in plugins/redhat-resource-optimization*; do
cd $plugin
npx -y @janus-idp/cli@^1.13.0 package export-dynamic-plugin
cd ..
done

# Uses "npm pack" to to create .tgz files containing the plugin static assets
DYNAMIC_PLUGIN_ROOT_DIR="./dynamic-plugins-root"
Expand Down
Loading

0 comments on commit ee3c9e7

Please sign in to comment.