feat(storagenode): add empty payload validation #1001
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1001 +/- ##
==========================================
+ Coverage 79.74% 79.85% +0.11%
==========================================
Files 178 178
Lines 21478 21493 +15
==========================================
+ Hits 17127 17163 +36
+ Misses 3562 3550 -12
+ Partials 789 780 -9 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ijsong
force-pushed
the
new_and_deprecated_opentelemetry_runtime_metrics
branch
from
d0cd709 to
0f36126
Compare
ijsong
force-pushed
the
append_empty_payload_validation
branch
from
19ff247 to
06ca186
Compare
hungryjang
approved these changes
Mar 6, 2025
ijsong
force-pushed
the
new_and_deprecated_opentelemetry_runtime_metrics
branch
from
0f36126 to
21cfc1d
Compare
ijsong
force-pushed
the
append_empty_payload_validation
branch
from
06ca186 to
f4daea5
Compare
ijsong
force-pushed
the
new_and_deprecated_opentelemetry_runtime_metrics
branch
from
21cfc1d to
469806f
Compare
ijsong
force-pushed
the
append_empty_payload_validation
branch
from
f4daea5 to
ecd80e5
Compare
ijsong
force-pushed
the
new_and_deprecated_opentelemetry_runtime_metrics
branch
from
469806f to
4df0785
Compare
ijsong
force-pushed
the
append_empty_payload_validation
branch
from
ecd80e5 to
4b4c051
Compare
ijsong
force-pushed
the
new_and_deprecated_opentelemetry_runtime_metrics
branch
from
4df0785 to
2d70879
Compare
ijsong
force-pushed
the
append_empty_payload_validation
branch
from
4b4c051 to
2c8a69b
Compare
ijsong
force-pushed
the
new_and_deprecated_opentelemetry_runtime_metrics
branch
from
2d70879 to
5bb0699
Compare
ijsong
force-pushed
the
append_empty_payload_validation
branch
from
2c8a69b to
7b17c35
Compare
ijsong
force-pushed
the
new_and_deprecated_opentelemetry_runtime_metrics
branch
from
5bb0699 to
1b1a201
Compare
ijsong
force-pushed
the
append_empty_payload_validation
branch
from
7b17c35 to
33d7d79
Compare
…e metrics This commit enables Varlog to support both new and deprecated OpenTelemetry runtime metrics. Previously, Varlog only supported the deprecated runtime instrumentation. This change ensures backward compatibility by simultaneously setting the `OTEL_GO_X_DEPRECATED_RUNTIME_METRICS` environment variable and using the new version. This enhancement allows Varlog to leverage the latest OpenTelemetry features while maintaining compatibility with older versions, collecting more comprehensive runtime metrics.
Add validation for empty payloads in the Append RPC. If there is no payload in the append request, the RPC returns a gRPC status code of InvalidArgument.
ijsong
force-pushed
the
new_and_deprecated_opentelemetry_runtime_metrics
branch
from
1b1a201 to
7777924
Compare
ijsong
force-pushed
the
append_empty_payload_validation
branch
from
33d7d79 to
4e574d8
Compare
Base automatically changed from
new_and_deprecated_opentelemetry_runtime_metrics
to
main
March 31, 2025 08:39
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Add validation for empty payloads in the Append RPC. If there is no payload in
the append request, the RPC returns a gRPC status code of InvalidArgument.