Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support zap logger's development mode #1004

Open
wants to merge 1 commit into
base: append_empty_payload_validation
Choose a base branch
from

Conversation

ijsong
Copy link
Member

@ijsong ijsong commented Mar 5, 2025

What this PR does

This PR adds a new flag --enable-development-mode to enable development mode
for the logger. If it is true, the logger panics at the DPanic level.

@ijsong ijsong requested a review from hungryjang as a code owner March 5, 2025 11:51
Copy link

codecov bot commented Mar 5, 2025

Codecov Report

Attention: Patch coverage is 66.66667% with 3 lines in your changes missing coverage. Please review.

Project coverage is 79.65%. Comparing base (4b4c051) to head (a580355).

Files with missing lines Patch % Lines
internal/flags/logger.go 50.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@                         Coverage Diff                         @@
##           append_empty_payload_validation    #1004      +/-   ##
===================================================================
- Coverage                            79.79%   79.65%   -0.15%     
===================================================================
  Files                                  178      178              
  Lines                                21493    21499       +6     
===================================================================
- Hits                                 17151    17124      -27     
- Misses                                3560     3587      +27     
- Partials                               782      788       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ijsong ijsong force-pushed the append_empty_payload_validation branch from 06ca186 to f4daea5 Compare March 6, 2025 10:23
@ijsong ijsong force-pushed the append_empty_payload_validation branch from f4daea5 to ecd80e5 Compare March 8, 2025 13:07
This PR adds a new flag `--enable-development-mode` to enable development mode
for the logger. If it is true, the logger panics at the DPanic level.
@ijsong ijsong force-pushed the append_empty_payload_validation branch from ecd80e5 to 4b4c051 Compare March 14, 2025 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants