Simplified version of your look_w function #1
Conversation
This reverts commit 1bf0341.
Saw your pull request: dwyl#38 Wanted to show you there was a simpler way to accomplish what you were doing. Also this solution returns words in the original case.
sys imported and unused. os only used to create cwd which is implied with open try/except block that doesn't handle anything json loaded to create a more expensive defaultdict dict created just for membership testing instead of set membership test performed by fetching key value instead of using in
|
Hi Stack-of-Pancakes, Thank you so much for the pull request. I am pretty amaze with the solutions you gave. I almost wanted to merge at once. However, i was taught that "one-liner" is more complex to understand. I did spend more time to understand it. Yesss, i agree that the existing one was too complex as well. But it made more clearer through comments. If you could just made changes on the comments, it will be much appreciated. I prefer that the solution will be made new (instead of changing the existing one). I am willing to merge your new approach and deleted the existing one instead (after some review approval). Thank you again, and hope you enjoy the rest of the repos as well. You are most welcome to suggest at the others as well. Wait for more pull request from you 😄 |
Saw your pull request: dwyl#38
What you were doing, finding words that could be made from word. It was a bit convoluted and I just wanted to show you it was basically a one-liner. All you had to do was check that the length was correct, and that the number of each letter being used was available in the source word.
Also this version only modifies the dictionary words when checking so when they are returned they maintain their case. You can see that in the 'quit' example.