Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Additional terraform example #48

Merged
merged 5 commits into from
Oct 4, 2023
Merged

Additional terraform example #48

merged 5 commits into from
Oct 4, 2023

Conversation

calbritt
Copy link
Contributor

@calbritt calbritt commented Oct 3, 2023

No description provided.

@calbritt
Add additional example
448eb09 
Signed-off-by: Cari Albritton <cari.albritton@kaleido.io>
@calbritt
add readme
467a08f 
Signed-off-by: Cari Albritton <cari.albritton@kaleido.io>
@codecov-commenter
Copy link

codecov-commenter commented Oct 3, 2023 •
edited
Loading

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (ca4ec77) 57.98% compared to head (52a1a0e) 57.98%.
Report is 2 commits behind head on master.

❗ Current head 52a1a0e differs from pull request most recent head 897b6b6. Consider uploading reports for the commit 897b6b6 to get more accurate results

Additional details and impacted files 
@@           Coverage Diff           @@
##           master      #48   +/-   ##
=======================================
  Coverage   57.98%   57.98%           
=======================================
  Files          13       13           
  Lines        1616     1616           
=======================================
  Hits          937      937           
  Misses        594      594           
  Partials       85       85

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

onelapahead
onelapahead approved these changes Oct 4, 2023
View reviewed changes
Copy link
Contributor

@onelapahead onelapahead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great, perhaps let's rename to multi_region_with_multi_party ?

examples/env_with_dxe/README.md Outdated Show resolved Hide resolved
@calbritt
multi region default
d034cc4 
Signed-off-by: Cari Albritton <cari.albritton@kaleido.io>
@calbritt
Update comments
5bd9104 
Signed-off-by: Cari Albritton <cari.albritton@kaleido.io>
@calbritt
Update variable name, add required provider, and remove quotes
897b6b6 
Signed-off-by: Cari Albritton <cari.albritton@kaleido.io>
@calbritt calbritt merged commit 0bb7fcf into master Oct 4, 2023
1 check passed
@calbritt calbritt deleted the besu branch October 4, 2023 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@onelapahead onelapahead onelapahead approved these changes

@peterbroadhurst peterbroadhurst peterbroadhurst approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@calbritt @codecov-commenter @peterbroadhurst @onelapahead