Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding variable set resource #76

Merged
merged 6 commits into from
Jun 19, 2024
Merged

Adding variable set resource #76

merged 6 commits into from
Jun 19, 2024

Conversation

hosie
Copy link
Contributor

@hosie hosie commented Jun 18, 2024

No description provided.

peterbroadhurst and others added 4 commits May 29, 2024 14:33
Signed-off-by: Peter Broadhurst <peter.broadhurst@kaleido.io>
Signed-off-by: Peter Broadhurst <peter.broadhurst@kaleido.io>
Signed-off-by: John Hosie <john.hosie@kaleido.io>
"description": &schema.StringAttribute{
Optional: true,
},
"variables_json": &schema.StringAttribute{
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Think this should be marked sensitive if it's a single type that spans things that might/might-not be senstive

Copy link
Member

@peterbroadhurst peterbroadhurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great - one thought on the variables to consider before merge

@hosie hosie mentioned this pull request Jun 19, 2024
@hosie hosie merged commit 8a1a8eb into v1.1 Jun 19, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants