-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[runtime] Support for storageSize, storageType, zone, and subZone #78
Conversation
Signed-off-by: Samim Mirhosseini <ssmirr@users.noreply.github.com>
Signed-off-by: Samim Mirhosseini <ssmirr@users.noreply.github.com>
Noticed the CI build is failing, but unlikely to be related to this specific PR as there seems to be a few other failures before this build. Current findings are:
I will keep looking and update here if I find something more interesting by tonight |
Signed-off-by: hfuss <hayden.fuss@kaleido.io>
…rver Signed-off-by: hfuss <hayden.fuss@kaleido.io>
#79 helped rule out what was going on with the tests - it was broken due to the missing But the resource / tests had a few bugs in the optional vs computed logic for the storage related fields which are optional for the user, and are only relevant for certain runtime types. I updated the test to manage a runtime with a specified zone, storage type, and storage size for now. Additional tests for non-storage runtimes and zone defaulting would be helpful in the future. |
@@ -52,7 +56,11 @@ type RuntimeAPIModel struct { | |||
EnvironmentMemberID string `json:"environmentMemberId,omitempty"` | |||
Status string `json:"status,omitempty"` | |||
Deleted bool `json:"deleted,omitempty"` | |||
Stopped bool `json:"stopped,omitempty"` | |||
Stopped bool `json:"stopped"` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Our API should always returns this, so if its false
we still want it in serialized JSON responses. Otherwise it was being omitted and the unit tests were broken.
Allows for leveraging the lower-level features of the platform to customize the scheduling and storage of runtimes, such as Besu and IPFS.