-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added origin_len, docstrings and tests #2
Conversation
Reviewer's Guide by SourceryThis PR enhances the AliasDict class by adding docstrings to all methods, introducing a new origin_len() method to get the length of the original dictionary without aliases, and reorganizing the len() implementation. The version has been bumped to 1.1.0 to reflect these additions. Updated class diagram for AliasDictclassDiagram
class AliasDict {
+AliasDict(dict_)
+add_alias(key, *aliases)
+remove_alias(*aliases)
+clear_aliases()
+aliases()
+aliased_keys()
+origin_keys()
+keys()
+values()
+items()
+origin_len()
+__len__()
+__missing__(key)
+__iter__()
+__repr__()
}
note for AliasDict "Added origin_len method and docstrings for all methods"
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @kaliv0 - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Summary by Sourcery
Add the 'origin_len' method to the AliasDict class, update documentation with new examples, and include tests for the new functionality. Enhance code readability by adding docstrings to all methods. Update the project version to 1.1.0.
New Features:
Enhancements:
Documentation:
Tests:
Chores: