Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added origin_len, docstrings and tests #2

Merged
merged 2 commits into from
Dec 17, 2024
Merged

added origin_len, docstrings and tests #2

merged 2 commits into from
Dec 17, 2024

Conversation

kaliv0
Copy link
Owner

@kaliv0 kaliv0 commented Dec 17, 2024

Summary by Sourcery

Add the 'origin_len' method to the AliasDict class, update documentation with new examples, and include tests for the new functionality. Enhance code readability by adding docstrings to all methods. Update the project version to 1.1.0.

New Features:

  • Introduce the 'origin_len' method to return the length of the original dictionary without aliases.

Enhancements:

  • Add docstrings to all methods in the AliasDict class to improve code readability and understanding.

Documentation:

  • Update README.md to include documentation and examples for the new 'origin_len' method.

Tests:

  • Add a new test to verify that the 'origin_len' method correctly excludes aliases from the count.

Chores:

  • Bump the project version from 1.0.0 to 1.1.0 in pyproject.toml to reflect new changes.

Copy link

sourcery-ai bot commented Dec 17, 2024

Reviewer's Guide by Sourcery

This PR enhances the AliasDict class by adding docstrings to all methods, introducing a new origin_len() method to get the length of the original dictionary without aliases, and reorganizing the len() implementation. The version has been bumped to 1.1.0 to reflect these additions.

Updated class diagram for AliasDict

classDiagram
    class AliasDict {
        +AliasDict(dict_)
        +add_alias(key, *aliases)
        +remove_alias(*aliases)
        +clear_aliases()
        +aliases()
        +aliased_keys()
        +origin_keys()
        +keys()
        +values()
        +items()
        +origin_len()
        +__len__()
        +__missing__(key)
        +__iter__()
        +__repr__()
    }
    note for AliasDict "Added origin_len method and docstrings for all methods"
Loading

File-Level Changes

Change Details Files
Added docstrings to all methods in the AliasDict class
  • Added descriptive docstrings to add_alias(), remove_alias(), and clear_aliases() methods
  • Added docstrings to all dictionary view methods (keys(), values(), items(), etc.)
  • Added docstrings to alias-specific methods (aliases(), aliased_keys(), origin_keys())
aldict/alias_dict.py
Implemented new origin_len() method and reorganized length-related functionality
  • Added new origin_len() method to get dictionary length excluding aliases
  • Moved len() implementation to be grouped with other special methods
  • Added test case for origin_len() method
aldict/alias_dict.py
tests/test_alias_dict.py
Updated documentation and version
  • Added documentation for origin_len() method with usage example
  • Bumped version from 1.0.0 to 1.1.0
README.md
pyproject.toml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @kaliv0 - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟡 General issues: 1 issue found
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@kaliv0 kaliv0 merged commit 87e1229 into main Dec 17, 2024
6 checks passed
@kaliv0 kaliv0 deleted the polish-code branch December 17, 2024 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant