fix for php 8.3

[alexandergotts]

updates codeigniter/framework to be compatible for php 8.2+ and removes fix that no longer works

[tenzap]

Please check #512
Is your PR still required?

[alexandergotts]

Please check #512 Is your PR still required?

I think my pr is no longer needed

[tenzap]

When doing squash & merge, use this commit message:

remove deprecated call to CI_Model::__construct()

In future CI3 version 3.2.0, that constructor is entirely removed,
which would result in fatal errors on attempts to call it.

See: https://github.com/bcit-ci/CodeIgniter/blob/develop/user_guide_src/source/installation/upgrade_320.rst

[alexandergotts]

get_class() not working with php 8.3

[tenzap]

In this case, and a few others, it seems it is advised to remove the constructor completely. See comment here: https://github.com/bcit-ci/CodeIgniter/blob/develop/user_guide_src/source/installation/upgrade_320.rst#step-3-remove-calls-to-ci_model__construct
There are other similar ones below.

[tenzap]

What about using __CLASS__ instead? Any advantage of it?

[alexandergotts]

works too. i have changed it

[kingster]

Shouldn't we remove the construct function itself? If there is nothing inside it?

[tenzap]

Shouldn't we remove the construct function itself? If there is nothing inside it?

That's what I meant in my comment above #510 (comment)

[alexandergotts]

Could work but it also works if you just leave it empty

[tenzap]

Could you please squash all the commits to leave only these two and set an appropriate commit message?

• one commit for the changes related to the constructor for CI3.2. I think it is cleaner to remove completely the empty constructors.
• one commit for the changes related to php 8.3 (__CLASS__)

[alexandergotts]

Could you please squash all the commits to leave only these two and set an appropriate commit message?

• one commit for the changes related to the constructor for CI3.2. I think it is cleaner to remove completely the empty constructors.
• one commit for the changes related to php 8.3 (__CLASS__)

I can only make one fork that I can commit

[tenzap]

You probably need to use the command line for that.

[tenzap]

Search for "git squash commit" in a search engine.

[alexandergotts]

it's done

[tenzap]

Thanks

[tenzap]

Replaced by #513 & #514