Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add support to sign range header #6

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

add support to sign range header #6

wants to merge 1 commit into from

Conversation

ofriedma
Copy link

@ofriedma ofriedma commented Feb 5, 2020

sign range header (For partial content)

add support to sign range header
2729eb9 
sign range header (For partial content)
@ofriedma ofriedma requested a review from erankor February 5, 2020 10:02
@erankor
Copy link
Collaborator

erankor commented Feb 5, 2020

As far as I can see in the docs (https://docs.aws.amazon.com/AmazonS3/latest/API/sig-v4-header-based-auth.html), signing the range is not mandatory - only Host and x-amz-* are required.
And, if that is indeed the case, I don't think it should be implemented this way, there should be a conf directive for adding additional headers. These headers would be kept in an ngx_hash_t that will looked up here.

@kaltura-hooks
Copy link

Hi @ofriedma,
Thank you for contributing this pull request!
Please sign the Kaltura CLA so we can review and merge your contribution.
Learn more at http://bit.ly/KalturaContrib

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erankor erankor Awaiting requested review from erankor

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ofriedma @erankor @kaltura-hooks