fix(SUP-43778):v7 Player Hotspot Text Formatting #326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
inbalvasserman
requested review from
MosheMaorKaltura,
semarche-kaltura,
JonathanTGold,
lianbenjamin and
SivanA-Kaltura
|
@inbalvasserman Try to upgrade cypress to 13.13.1 (fixed version, no caret). This should fix the firefox timeout. |
SivanA-Kaltura
requested changes
Aug 15, 2024
SivanA-Kaltura
requested changes
Aug 15, 2024
semarche-kaltura
approved these changes
Aug 19, 2024
SivanA-Kaltura
approved these changes
Sep 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue:
*hotspots didn't break line (in kea it breaks lines)
*when change player size the hotspots text and border radius didn't changed accordingly
solution:
*change css style to fit to kea style and allow break lines
*calculate the font size and border radius relatively to player size
solved SUP-43778