fix(FEC-13709): remove player top bar if there is no content in it #883
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lianbenjamin
requested review from
MosheMaorKaltura,
semarche-kaltura,
JonathanTGold and
SivanA-Kaltura
JonathanTGold
approved these changes
May 12, 2024
SivanA-Kaltura
requested changes
May 12, 2024
SivanA-Kaltura
approved these changes
May 15, 2024
lianbenjamin
added a commit
to kaltura/playkit-js-ui-managers
that referenced
this pull request
May 15, 2024
### Description of the Changes - bugfix. do not render the `DisplayedBarComponentWrapper` root element in case there are no components to render within. related PR: kaltura/playkit-js-ui#883 Solves FEC-13709 ### CheckLists - [ ] changes have been done against master branch, and PR does not conflict - [ ] new unit / functional tests have been added (whenever applicable) - [ ] test are passing in local environment - [ ] Travis tests are passing (or test results are not worse than on master branch :)) - [ ] Docs have been updated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Changes
set
visibility: hiddento top bar component in case left and right controls do not contain any children (top bar is empty).related PR: kaltura/playkit-js-ui-managers#53
Resolves FEC-13709