Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(FEC-14059): fix the height of scrollable component #909

Merged
merged 1 commit into from
Jul 24, 2024
Merged

fix(FEC-14059): fix the height of scrollable component #909

merged 1 commit into from
Jul 24, 2024

Conversation

lianbenjamin
Copy link
Collaborator

Description of the Changes

bugfix - regression.

Issue:
recent changes in scrollable component have caused More dropdown to not change its height dynamically.
the root cause is the new height style that was added, which exists in cases where it shouldn't.

Fix:

  • make an accurate calculation to check if there is enough space for the scrollable items inside the parent's container
  • set height and remove height style according to the calculation

Resolves FEC-14059, FEC-14060

@lianbenjamin lianbenjamin merged commit 9e4f6ec into master Jul 24, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SivanA-Kaltura SivanA-Kaltura SivanA-Kaltura approved these changes

@semarche-kaltura semarche-kaltura semarche-kaltura approved these changes

@MosheMaorKaltura MosheMaorKaltura Awaiting requested review from MosheMaorKaltura

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lianbenjamin @semarche-kaltura @SivanA-Kaltura